Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factor out sizing mode mixin and force height of ChatFeed to stretch #7744

Merged
merged 3 commits into from
Mar 1, 2025

Conversation

philippjfr
Copy link
Member

Factoring out the sizing_mode mix-in class allows downstream libraries to emulate the behavior of Panel layouts more easily. Additionally we fix some workarounds used to force the Feed inside the ChatFeed to stretch in height.

Copy link

codecov bot commented Feb 28, 2025

Codecov Report

Attention: Patch coverage is 96.05263% with 3 lines in your changes missing coverage. Please review.

Project coverage is 87.10%. Comparing base (0eb63a0) to head (16b2af7).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
panel/layout/base.py 96.05% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7744      +/-   ##
==========================================
- Coverage   87.10%   87.10%   -0.01%     
==========================================
  Files         346      346              
  Lines       52759    52758       -1     
==========================================
- Hits        45956    45953       -3     
- Misses       6803     6805       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr philippjfr merged commit d8df149 into main Mar 1, 2025
18 checks passed
@philippjfr philippjfr deleted the sizing_mode_mixin branch March 1, 2025 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant